Re: [PATCH v3 2/2] merge-base: teach "--fork-point" mode

From: John Keeping <john@keeping.me.uk>
Date: Oct 26, 2013, 09:00 UTC
Message-ID: <20131026090034.GH10779@serenity.lan>
In-Reply-To: <xmqq61sljakf.fsf_-_@gitster.dls.corp.google.com>

On Fri, Oct 25, 2013 at 02:38:08PM -0700, Junio C Hamano wrote:

Show 5 quoted lines

>  It also comes with a documentation update. The option is not called
>  --reflog but --fork-point; naming a feature after what it does
>  (i.e. it finds the fork point) is a lot more sensible than naming
>  it after how it happens to do what it does (i.e. it does so by
>  peeking into the reflog).

I think the new name is likely to confuse normal users - when talking about a branch, you can talk about where it forked from and in that case it normally means the merge-base of that branch and master.

The --reflog name has the advantage that it makes clear that this is looking at something more than the commit graph and I don't think --fork-point does imply that.