Re: Issue with compiling git 1.8.4 under uclibc with gcc 4.6.3

From: Jeff King <peff@peff.net>
Date: Aug 26, 2013, 20:59 UTC
Message-ID: <20130826205901.GC23598@sigill.intra.peff.net>
In-Reply-To: <20130826203154.GA21357@blizzard>

On Mon, Aug 26, 2013 at 10:31:54PM +0200, Lukas Fleischer wrote:

Show 8 quoted lines

> > I also had to change line 224 to the following
> > 
> >                 c = (cf->fgetc)(cf);
> > 
> > Once both places were changes, it compiled successfully.
> 
> Sounds like a parser bug to me. Should we patch this in Git in order to
> make it compile with (broken?) GCC versions?

Hmm. I wonder if fgetc is a macro in uclibc? Just grepping their stdio.h, it looks like that is a possibility.

I think they are probably wrong to do so (but I'd have to check the standard). However, the cleaner workaround would probably be to call the fgetc struct member something else.

-Peff