Re: Issue with compiling git 1.8.4 under uclibc with gcc 4.6.3

From: Lukas Fleischer <git@cryptocrack.de>
Date: Aug 26, 2013, 20:31 UTC
Message-ID: <20130826203154.GA21357@blizzard>
In-Reply-To: <521BBA98.7010102@gmail.com>

On Mon, Aug 26, 2013 at 02:29:12PM -0600, Lance wrote:

Show 17 quoted lines

> [...]
> >>     CC config.o
> >>config.c: In function 'get_next_char':
> >>config.c:220:14: error: expected identifier before '(' token
> >>config.c:220:14: error: expected statement before ')' token
> >>config.c:220:14: error: expected statement before ')' token
> >>config.c:224:11: error: expected identifier before '(' token
> >Does changing line 220 of config.c to
> >
> >     int c = (cf->fgetc)(cf);
> >
> >fix it?
> I also had to change line 224 to the following
> 
>                 c = (cf->fgetc)(cf);
> 
> Once both places were changes, it compiled successfully.

Sounds like a parser bug to me. Should we patch this in Git in order to make it compile with (broken?) GCC versions?

> [...]