Re: [PATCH v2] compat: Fix read() of 2GB and more on Mac OS X
On Mon, Aug 19, 2013 at 08:38:20AM +0200, Steffen Prohaska wrote:
Show 21 quoted lines
> diff --git a/Makefile b/Makefile
> index 3588ca1..0f69e24 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -69,6 +69,9 @@ all::
> # Define NO_MSGFMT_EXTENDED_OPTIONS if your implementation of msgfmt
> # doesn't support GNU extensions like --check and --statistics
> #
> +# Define NEEDS_CLIPPED_READ if your read(2) cannot read more than
> +# INT_MAX bytes at once (e.g. MacOS X).
> +#
> # Define NEEDS_CLIPPED_WRITE if your write(2) cannot write more than
> # INT_MAX bytes at once (e.g. MacOS X).
> #
> @@ -1493,6 +1496,11 @@ ifndef NO_MSGFMT_EXTENDED_OPTIONS
> MSGFMT += --check --statistics
> endif
>
> +ifdef NEEDS_CLIPPED_READ
> + BASIC_CFLAGS += -DNEEDS_CLIPPED_READ
> + COMPAT_OBJS += compat/clipped-read.o
You've created compat/clipped-write.c, but...
Show 7 quoted lines
> Makefile | 8 ++++++++
> builtin/var.c | 1 +
> config.mak.uname | 1 +
> git-compat-util.h | 5 +++++
> streaming.c | 1 +
> t/t0021-conversion.sh | 14 ++++++++++++++
> 6 files changed, 30 insertions(+)
... it's not included here. Did you forget to "git add"?
John Keeping <john@keeping.me.uk>