git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug: commit -p breaks with -m

From
Jeff King <peff@peff.net>
Date
Aug 15, 2013, 17:31 UTC
Message-ID
<20130815173158.GA27866@sigill.intra.peff.net>
In-Reply-To
<7v1u5usw27.fsf@alter.siamese.dyndns.org>
On Thu, Aug 15, 2013 at 10:28:16AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Unfortunately, I think that will require some refactoring of the
> > run_hook interface, which does not allow arbitrary environment
> > parameters to be set.
> 
> Heh, I said that long time ago, e.g. $gmane/212284 ;-)
> 
> This might turn out to be a good starting point, even though I
> didn't read it again before sending this message.
> 
>     http://thread.gmane.org/gmane.comp.version-control.git/192669/focus=192806

Looking at both of those messages, I agree completely. I even started to sketch out the refactoring when I sent the previous message, and it looked a lot like the patch you sent.

-Peff
Previous: Junio C Hamano
Message 4 of 4 in “Bug: commit -p breaks with -m”
  1. Matan NassauAug 15, 2013
  2. Jeff KingAug 15, 2013
  3. Junio C HamanoAug 15, 2013
  4. Jeff KingAug 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.