From: Jeff King Date: Thu, 15 Aug 2013 17:31:58 GMT Subject: Re: Bug: commit -p breaks with -m Message-ID: <20130815173158.GA27866@sigill.intra.peff.net> In-Reply-To: <7v1u5usw27.fsf@alter.siamese.dyndns.org> On Thu, Aug 15, 2013 at 10:28:16AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Unfortunately, I think that will require some refactoring of the > > run_hook interface, which does not allow arbitrary environment > > parameters to be set. > > Heh, I said that long time ago, e.g. $gmane/212284 ;-) > > This might turn out to be a good starting point, even though I > didn't read it again before sending this message. > > http://thread.gmane.org/gmane.comp.version-control.git/192669/focus=192806 Looking at both of those messages, I agree completely. I even started to sketch out the refactoring when I sent the previous message, and it looked a lot like the patch you sent. -Peff