Re: [PATCH 3/3] config: --get-urlmatch
- From
Jeff King <peff@peff.net>
- Date
- Jul 30, 2013, 08:14 UTC
- Message-ID
- <20130730081413.GC16693@sigill.intra.peff.net>
- In-Reply-To
- <7vbo5kzv9k.fsf@alter.siamese.dyndns.org>
On Mon, Jul 29, 2013 at 06:33:43PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Jeff King <peff@peff.net> writes:
>
> >> +struct urlmatch_item {
> >> + size_t max_matched_len;
> >> + char user_matched;
> >> + char value_is_null;
> >> + struct strbuf value;
> >> +};
> >
> > I think you ultimately want such a string_list for matching arbitrary
> > numbers of keys, but do you need it for the git-config case?
>
> "git config" does not know the semantics of each key, nor available
> set of keys, no? The string-list is only to support
>
> git config --get-urlmatch http http://www.google.com/
>
> i.e. "list everything under http.* hierarchy".Ah, I missed that you could leave "key" empty. I had expected collect->key to be filled in, at which point you only ever have one such key (and you do not need to know the semantics, only which one is the "winner").
-Peff