git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] "git config --get-urlmatch $section.$key $url"

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 29, 2013, 22:49 UTC
Message-ID
<1375138150-19520-1-git-send-email-gitster@pobox.com>
In-Reply-To
<7vli4v66b3.fsf@alter.siamese.dyndns.org>

So here is a bit of refactoring to extract the logic to find the entry $section.<urlpattern>.$key from the configuration that best matches the given $url to answer "what value $section.$key should be for $url?" out of http.c (primarily because we never want to link "git cofnig" with the cURL library), and use it from "git config" to implement Peff's idea to extend "git config".

The first step is a pure code movement, plus some renaming of the functions.

The second step is to factor out the code to handle --bool, --int, etc. as a helper so that the new codepath can use it.

The last step currently duplicates the logic in http_options(), but we might want to refactor it further so that the two functions can share more code. We hopefully can get rid of test-url-normalize and instead use "git config --get-urlmatch" in the tests that protect the http.<url>.config topic.

Junio C Hamano (3):
  url-match: split out URL matching logic out of http.c
  builtin/config: refactor collect_config()
  config: --get-urlmatch
 Makefile             |   2 +
 builtin/config.c     | 183 ++++++++++++++++---
 http.c               | 500 +--------------------------------------------------
 test-url-normalize.c |   2 -
 url-match.c          | 468 +++++++++++++++++++++++++++++++++++++++++++++++
 url-match.h          |  35 ++++
 6 files changed, 671 insertions(+), 519 deletions(-)
 create mode 100644 url-match.c
 create mode 100644 url-match.h
-- 
1.8.4-rc0-137-g17832d4
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 19 in “test-url-normalize.c: Fix gcc errors and sparse warnings”
  1. test-url-normalize.c: Fix gcc errors and sparse warningsRamsay Jones, Jul 24, 2013
  2. Kyle J. McKayJul 24, 2013
  3. Junio C HamanoJul 24, 2013
  4. 0/3 "git config --get-urlmatch $section.$key $url"Junio C Hamano, Jul 29, 2013
  5. 1/3 url-match: split out URL matching logic out of http.cJunio C Hamano, Jul 29, 2013
  6. 2/3 builtin/config: refactor collect_config()Junio C Hamano, Jul 29, 2013
  7. 3/3 config: --get-urlmatchJunio C Hamano, Jul 29, 2013
  8. Jeff KingJul 30, 2013
  9. Junio C HamanoJul 30, 2013
  10. Jeff KingJul 30, 2013
  11. Junio C HamanoJul 30, 2013
  12. Kyle J. McKayJul 30, 2013
  13. 4/3 url-match: generalize configuration collection logicJunio C Hamano, Jul 30, 2013
  14. 5/3 revert most of the http_options() changeJunio C Hamano, Jul 30, 2013
  15. Kyle J. McKayJul 30, 2013
  16. Kyle J. McKayJul 30, 2013
  17. Junio C HamanoJul 30, 2013
  18. Ramsay JonesJul 31, 2013
  19. Junio C HamanoJul 31, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.