git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] commit.h: drop redundant comment

From
Jeff King <peff@peff.net>
Date
Jul 25, 2013, 20:01 UTC
Message-ID
<20130725200059.GA1225@sigill.intra.peff.net>

We mention twice that the from_ident field of struct pretty_print_context is internal.

The first comment was added by 10f2fbf, which prepares the struct for internal fields, and then the second by a908047, which actually adds such a field. This was a mistake made when re-rolling the series on the list; the comment should have been removed from the latter commit.

Signed-off-by: Jeff King <peff@peff.net>
---
Not that important, really. I only bothered tracking down the source of
the error because I was curious if it was a mis-merge or something. But
nope, just me screwing up, and missing it in review.
 commit.h | 2 --
 1 file changed, 2 deletions(-)
diff --git a/commit.h b/commit.h
index 35cc4e2..d912a9d 100644
--- a/commit.h
+++ b/commit.h
@@ -102,8 +102,6 @@ struct pretty_print_context {
 	 * Fields below here are manipulated internally by pp_* functions and
 	 * should not be counted on by callers.
 	 */
-
-	/* Manipulated by the pp_* functions internally. */
 	struct string_list in_body_headers;
 };
 
-- 
1.8.3.rc1.30.gff0fb75
Message 1 of 1 in “commit.h: drop redundant comment”
  1. commit.h: drop redundant commentJeff King, Jul 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.