threads / patch / 34535

patchcommit.h: drop redundant comment

Subject: [PATCH] commit.h: drop redundant comment

## tl;dr

One message between Jul 25, 2013 and Jul 25, 2013. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jeff King· Jul 25, 2013, 20:01 UTC · lore

We mention twice that the from_ident field of struct pretty_print_context is internal.

The first comment was added by 10f2fbf, which prepares the struct for internal fields, and then the second by a908047, which actually adds such a field. This was a mistake made when re-rolling the series on the list; the comment should have been removed from the latter commit.

Signed-off-by: Jeff King <peff@peff.net>
---
Not that important, really. I only bothered tracking down the source of
the error because I was curious if it was a mis-merge or something. But
nope, just me screwing up, and missing it in review.
 commit.h | 2 --
 1 file changed, 2 deletions(-)
Show changes to commit.h +0 −2
diff --git a/commit.h b/commit.h
index 35cc4e2..d912a9d 100644
--- a/commit.h
+++ b/commit.h
@@ -102,8 +102,6 @@ struct pretty_print_context {
 	 * Fields below here are manipulated internally by pp_* functions and
 	 * should not be counted on by callers.
 	 */
-
-	/* Manipulated by the pp_* functions internally. */
 	struct string_list in_body_headers;
 };
 
-- 
1.8.3.rc1.30.gff0fb75

← back to recent threads