Re: send-email adds redundant From: lines to message body

From: Michael S. Tsirkin <mst@redhat.com>
Date: Jun 18, 2013, 11:42 UTC
Message-ID: <20130618114207.GD26857@redhat.com>
In-Reply-To: <20130618110904.GA20052@goldbirke>

On Tue, Jun 18, 2013 at 01:09:04PM +0200, SZEDER Gábor wrote:

Show 6 quoted lines

> Hi,
> 
> 'git send-email' recently started to add redundant From: lines to my
> messages, see e.g.
> 
>   http://article.gmane.org/gmane.comp.version-control.git/228132

Can you please show what do commits point to? E.g. push to some public tree?

Show 39 quoted lines

> Bisect points to:
> 
> commit da18759e86bb1a7ee718c79a0c6cb15fbcbdf3c2
> Author: Michael S. Tsirkin <mst@redhat.com>
> Date:   2013-06-05 21:11:00 +0300
> 
>     send-email: make --suppress-cc=self sanitize input
>     
>     --suppress-cc=self fails to filter sender address in many cases where it
>     needs to be sanitized in some way, for example quoted:
>     "A U. Thor" <author@example.com>
>     To fix, make send-email sanitize both sender and the address it is
>     compared against.
>     
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> The exact commands I run were:
> 
>   git format-patch --cover-letter --subject-prefix='PATCH v2' 2847cae835fa70f00e6e2286fbfa5595cb2247d0..bash-prompt-speedup
>   vim 0000-cover-letter.patch
>   git send-email --to=git@vger.kernel.org 00*
> 
> i.e. no '--suppress-cc=self' option at all.  Values of related config
> variables are:
> 
>   git config --get-regexp '(sendemail|user)\..*'
>   sendemail.smtpserver /usr/local/bin/putmail
>   sendemail.confirm auto
>   user.name SZEDER Gábor
>   user.email szeder@ira.uka.de
> 
> The 'á' in my first name is apparently significant: creating a commit
> and sending it as a patch with that accent removed doesn't trigger a
> redundant From: line.
> 
> 
> Thanks,
> Gábor