git/list[1] front-page[2] threads[3] people[4] search[5] about
 

send-email adds redundant From: lines to message body

From
SZEDER Gábor <szeder@ira.uka.de>
Date
Jun 18, 2013, 11:09 UTC
Message-ID
<20130618110904.GA20052@goldbirke>
Hi,

'git send-email' recently started to add redundant From: lines to my messages, see e.g.

  http://article.gmane.org/gmane.comp.version-control.git/228132
Bisect points to:
commit da18759e86bb1a7ee718c79a0c6cb15fbcbdf3c2
Author: Michael S. Tsirkin <mst@redhat.com>
Date:   2013-06-05 21:11:00 +0300
    send-email: make --suppress-cc=self sanitize input
    
    --suppress-cc=self fails to filter sender address in many cases where it
    needs to be sanitized in some way, for example quoted:
    "A U. Thor" <author@example.com>
    To fix, make send-email sanitize both sender and the address it is
    compared against.
    
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
The exact commands I run were:
  git format-patch --cover-letter --subject-prefix='PATCH v2' 2847cae835fa70f00e6e2286fbfa5595cb2247d0..bash-prompt-speedup
  vim 0000-cover-letter.patch
  git send-email --to=git@vger.kernel.org 00*

i.e. no '--suppress-cc=self' option at all. Values of related config variables are:

  git config --get-regexp '(sendemail|user)\..*'
  sendemail.smtpserver /usr/local/bin/putmail
  sendemail.confirm auto
  user.name SZEDER Gábor
  user.email szeder@ira.uka.de

The 'á' in my first name is apparently significant: creating a commit and sending it as a patch with that accent removed doesn't trigger a redundant From: line.

Thanks, Gábor

Next: Michael S. Tsirkin
Message 1 of 5 in “send-email adds redundant From: lines to message body”
  1. SZEDER GáborJun 18, 2013
  2. Michael S. TsirkinJun 18, 2013
  3. SZEDER GáborJun 18, 2013
  4. Michael S. TsirkinJun 18, 2013
  5. Michael S. TsirkinJun 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.