Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

From: Jeff King <peff@peff.net>
Date: May 11, 2013, 08:45 UTC
Message-ID: <20130511084543.GA1905@sigill.intra.peff.net>
In-Reply-To: <CAJDDKr7-sMrX=2Aek1LY8knM2jFPs933eLj3iZdTa68YYv-6Og@mail.gmail.com>

On Sat, May 11, 2013 at 01:38:32AM -0700, David Aguilar wrote:

Show 14 quoted lines

> > Adding "--verify-objects" would sha1 the blobs, too, which might be more
> > reasonable (or running "git fsck"). Something like "git add" on a large
> > blob would also be a good test.
> 
> Thanks.  Here are the numbers with --verify-objects:
> 
> $ time git rev-list --all --objects --verify-objects >/dev/null
> 
> # CommonCrypto 32.24s user 4.65s system 99% cpu 37.098 total
> # master       33.00s user 4.68s system 99% cpu 37.852 total
> # BLK_SHA1     54.17s user 4.67s system 99% cpu 58.928 total
> 
> Doing BLK_SHA1 seems like less of a good idea now, so I think my
> latest re-roll might be the way to go...

Wow, that's really terrible. What level of optimization do you compile with? With the other implementations, you are calling into (presumably) optimized library code, but with BLK_SHA1 you are getting whatever you just compiled.

Here are three timings that show how big a difference that can make:

  openssl,  -O0    0m21.152s
  BLK_SHA1, -O0    0m31.920s
  BLK_SHA1, -O3    0m19.652s

So it is a win over openssl with optimizations on, but a pretty big loss otherwise.

-Peff