Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- May 11, 2013, 06:23 UTC
- Message-ID
- <20130511062336.GD3394@elie>
- In-Reply-To
- <1368240282-89581-1-git-send-email-davvid@gmail.com>
Hi,
David Aguilar wrote:
Show 7 quoted lines
> Mac OS X Mountain Lion prints warnings when building git: > > warning: 'SHA1_Init' is deprecated > (declared at /usr/include/openssl/sha.h:121) > > Silence the warnings by using the Common Digest SHA-1 > functions for SHA1_Init(), SHA1_Update(), and SHA1_Final().
Thanks.
Does this perform better or worse than just setting BLK_SHA1=YesPlease? I'd naively think it could go either way: on one hand adding another library dependency can slow down startup, and on the other hand the implementation may or may not be optimized better than the generic block-sha1/ implementation.
Curious, Jonathan