Re: [PATCH 6/6] compat/nedmalloc: Fix compiler warnings on linux

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 29, 2013, 05:06 UTC
Message-ID: <20130429050616.GB8031@elie.Belkin>
In-Reply-To: <517C1CF9.2080903@ramsay1.demon.co.uk>

Hi,

Ramsay Jones wrote:

Show 9 quoted lines

> --- a/compat/nedmalloc/malloc.c.h
> +++ b/compat/nedmalloc/malloc.c.h
> @@ -484,6 +484,10 @@ MAX_RELEASE_CHECK_RATE   default: 4095 unless not HAVE_MMAP
>  #define DLMALLOC_VERSION 20804
>  #endif /* DLMALLOC_VERSION */
> 
> +#if defined(linux)
> +#define _GNU_SOURCE 1
> +#endif

If we want to do this, I'd suggest defining _GNU_SOURCE unconditionally. Other platforms using glibc would benefit from it, too, and other platforms not using glibc shouldn't care.

Alternatively it could make sense to see if the latest version from Niall Douglas[1] works, which includes the following:

	#ifndef HAVE_MREMAP
	#ifdef linux
	#define HAVE_MREMAP 1
	#ifndef _GNU_SOURCE
	#define _GNU_SOURCE /* Turns on mremap() definition */
	#endif
	#else   /* linux */
	#define HAVE_MREMAP 0
	#endif  /* linux */
	#endif  /* HAVE_MREMAP */

It looks equally wrong there, but since it comes from upstream we could just punt to him if anyone runs into problems. ;-)

My two cents, Jonathan

[1] http://www.nedprod.com/programs/portable/nedmalloc/