Re: [PATCH v2 4/5] check-ignore: allow incremental streaming of queries via --stdin
- From
Adam Spiers <git@adamspiers.org>
- Date
- Apr 24, 2013, 08:02 UTC
- Message-ID
- <20130424080235.GC17889@pacific.linksys.moosehall>
- In-Reply-To
- <7vbo96phmn.fsf@alter.siamese.dyndns.org>
On Mon, Apr 22, 2013 at 11:03:44AM -0700, Junio C Hamano wrote:
Show 23 quoted lines
> Adam Spiers <git@adamspiers.org> writes: > > > On Thu, Apr 11, 2013 at 03:11:32PM -0400, Jeff King wrote: > >> I always get a little nervous with sleeps in the test suite, as they are > >> indicative that we are trying to avoid some race condition, which means > >> that the test can fail when the system is under load, or when a tool > >> like valgrind is used which drastically alters the timing (e.g., if > >> check-ignore takes longer than 1 second to produce its answer, we may > >> fail here). > > > > Agreed, especially here where my btrfs filesystems see fit to kindly > > freeze my system for a few seconds many times each day :-/ > > > >> Is there a simpler way to test this? > >> > >> Like: > >> ... > > I'll re-roll using your approach. > > I think I missed this one and it already is in 'next'. > > I'll hold it back so please make your re-roll into an incremental > update.
Will do - will probably take a few days more though, since I'm currently catching up on a post-travel work backlog.