Re: [PATCH 2/5] check-ignore: allow incremental streaming of queries via --stdin

From: Jeff King <peff@peff.net>
Date: Apr 11, 2013, 18:33 UTC
Message-ID: <20130411183344.GA3177@sigill.intra.peff.net>
In-Reply-To: <20130411112000.GC24296@pacific.linksys.moosehall>

On Thu, Apr 11, 2013 at 12:20:00PM +0100, Adam Spiers wrote:

Show 11 quoted lines

> On Thu, Apr 11, 2013 at 02:59:32AM +0100, Adam Spiers wrote:
> > +test_expect_success STDBUF 'streaming support for --stdin' '
> > +	(
> > +		echo one
> > +		sleep 2
> > +		echo two
> > +	) | stdbuf -oL git check-ignore -v -n --stdin >out &
> 
> I just noticed that this patch precedes the one in the same series
> which adds -n support.  I'll reorder them accordingly to avoid
> breaking git bisect.

Thanks for noticing. FWIW, I often do this:

  GIT_EDITOR='sed -i "/^pick /aexec make test" \
  git rebase -i origin/master

on my topics to make sure each commit compiles and passes the tests in isolation (it will stop on a failure, at which point you can fix up and "git rebase --continue").

It's somewhat annoying, because it runs the whole test suite, even for commits that are obviously not going to have an impact (e.g., doc updates, or change to a single test). But it has saved me from embarrassment many times, when I thought for sure that my commits were obviously correct. :)

-Peff