Re: regression: "96b9e0e3 config: treat user and xdg config permission problems as errors" busted git-daemon
- From
Jeff King <peff@peff.net>
- Date
- Apr 12, 2013, 16:16 UTC
- Message-ID
- <20130412161600.GA20492@sigill.intra.peff.net>
- In-Reply-To
- <7vk3o7g29s.fsf@alter.siamese.dyndns.org>
On Fri, Apr 12, 2013 at 09:08:31AM -0700, Junio C Hamano wrote:
> OK, then...
> -- >8 -- > Subject: [PATCH] doc: clarify that "git daemon --user=<user>" option does not export HOME=~user
I'd add this motiviation to the body of the commit message:
The fact that we don't set $HOME may confuse admins who expect $HOME/.gitconfig to be respected. And worse, since 96b9e0e3, a git-daemon started by root is likely to fail to run at all, as the user we switch to generally cannot read ~root.
This still feels ugly, like we are documenting some gotcha that is going to hit most admins, when we could be helping them in the code.
One option we have not explored is an environment variable to loosen git's requirement. I'm thinking something like GIT_INACCESSIBLE_HOMEDIR_OK, which could be set by default when git-daemon uses --user.
That would leave all existing setups working, but would still enable the extra protections for people not running git-daemon (and people who use git via sudo could choose to set it, too, if they would prefer that to setting up HOME).
-Peff