Re: regression: "96b9e0e3 config: treat user and xdg config permission problems as errors" busted git-daemon

From: W. Trevor King <wking@tremily.us>
Date: Apr 10, 2013, 13:56 UTC
Message-ID: <20130410135605.GB4694@odin.tremily.us>
In-Reply-To: <1365572015.4658.51.camel@marge.simpson.net>

On Wed, Apr 10, 2013 at 07:33:35AM +0200, Mike Galbraith wrote:

Show 13 quoted lines

> /usr/lib/git/git-daemon --syslog --detach --reuseaddr --user=git --group=daemon --pid-file=/var/run/git-daemon.pid --export-all --user-path --enable=receive-pack
> 
> Try to pull as root or normal user results in:
> 
> [pid 26786] access("/root/.config/git/config", R_OK) = -1 EACCES (Permission denied)
> [pid 26786] write(2, "fatal: unable to access '/root/."..., 70) = 70
> [pid 26785] <... read resumed> "fatal: unable to access '/root/."..., 4096) = 70
> [pid 26786] exit_group(128)
> 
> Bisection fingered this commit, though it looks like it's really due to
> not forgetting who it was at birth.  It's not root, so has no business
> rummaging around in /root.  It used to not care, but this commit made
> "go away" while looking for non-existent config file terminal.

I ran into this too, although I'm running git-daemon via spawn-fcgi. In order to convince newer Gits that you know what you're doing, you just need to set HOME to somewhere Git can look. For example:

  HOME=/ /usr/lib/git/git-daemon …

should work. On Gentoo, I added the following to /etc/conf.d/spawn-fcgi.fcgiwrap:

  ALLOWED_ENV="PATH HOME"
  HOME=/

Cheers, Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy