Re: [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 22, 2013, 21:21 UTC
Message-ID: <20130322212159.GJ12223@google.com>
In-Reply-To: <1363938756-13722-5-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

Show 7 quoted lines

>                            This patch has no visible impact, but
> serves to enable future patches to introduce configuration variables
> to set pushremote_name.  For example, you can now do the following in
> handle_config():
>
>     if (!strcmp(key, "remote.pushdefault"))
>        git_config_string(&pushremote_name, key, value);

Thanks.

[...]

Show 8 quoted lines

> --- a/builtin/push.c
> +++ b/builtin/push.c
> @@ -322,7 +322,7 @@ static int push_with_options(struct transport *transport, int flags)
>  static int do_push(const char *repo, int flags)
>  {
>  	int i, errs;
> -	struct remote *remote = remote_get(repo);
> +	struct remote *remote = pushremote_get(repo);

"struct remote" has url and pushurl fields. What do they mean in the context of these two accessors? /me is confused.

Is the idea that now I should not use pushurl any more, and that I should use pushremote_get and use url instead?

Hope that helps, Jonathan