Re: [RFC] Add posibility to preload stat information.
- From
Fredrik Gustafsson <iveqy@iveqy.com>
- Date
- Mar 20, 2013, 18:36 UTC
- Message-ID
- <20130320183641.GB32426@paksenarrion.iveqy.com>
- In-Reply-To
- <CALkWK0nCY3o_KW8ykq9TkzfHeVj6NKDkOFuym9UmSWLH0ZFxBw@mail.gmail.com>
On Wed, Mar 20, 2013 at 11:19:38PM +0530, Ramkumar Ramachandra wrote:
> I think it should be a separate script in contrib/ that people can > just `eval` in their shell configs; zsh has a chpwd() function for > example, which seems like the right place to put such a thing.
I was trying to spare the number of calls to "git rev-parse --is-inside-work-tree". But maybe that is to fast to care about.
> No, I meant in the commit message.
Okay, thanks.
Show 9 quoted lines
> >> That said, this feature is extremely gross; it thrashes my filesystem > >> and hard drive. Modern software is written to minimize IO, not > >> maximize it! I'm completely against the inclusion of this patch. > > > > It's extremly gross. I don't like this, _but_ it does speed up my work. > > I'm unsure if it should be included in git though (hence the RFC-tag). > > Yes, I would certainly like my git startup time to be improved. But I > don't want to trade my hard drive's life for it.
Does this really increase disk-reads? The fs-cache would make sure that the disk reads is almost the same, we only do them before we usually do them.
> What I meant by "first time" is "chpwd() into the git repository, not > further chpwd()s when already inside the git repository".
That's a good point. I'm not sure how to solve that though. Because it's not a fact that you always go to the root git-dir first.
The only way I see this is with a lock-file that's kept and we only run git status every 5 minutes when doing something inside a work dir. That would add a lot of meta-data (the lock files), to store. (I hope I successfully explained that).
-- Med vänliga hälsningar Fredrik Gustafsson tel: 0733-608274 e-post: iveqy@iveqy.com