Re: [RFC] Add posibility to preload stat information.

From: Jeff King <peff@peff.net>
Date: Mar 20, 2013, 17:47 UTC
Message-ID: <20130320174759.GA29349@sigill.intra.peff.net>
In-Reply-To: <7vhak6f0w4.fsf@alter.siamese.dyndns.org>

On Wed, Mar 20, 2013 at 10:15:39AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > So maybe just run "git status >/dev/null"?
> 
> In the background?  How often would it run?  I do not think a single
> lockfile solves anything.  It may prevent simultaneous runs of two
> such "prime the well" processes, but the same user may be working in
> two separate repositories.

Yes, in the background (he invokes __git_recursive_stat already in the background). I'd think you would want to run it whenever you enter a repository.

> I do not see anything that prevents it from running in the same
> repository over and over again, either.  "prompt" is a bad place to
> do this kind of thing.

Yeah, I did not look closely at that. The commit message claims "When entering a git working dir", but the implementation runs it on each prompt invocation, which is awful. I think you'd want to check to use rev-parse to see if you have changed into a new git repo, and only run it once then.

Which is still gross, and I have no interest whatsoever in this feature. I was just trying to be positive and constructive to the original submission. :)

-Peff