git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

From
Jeff King <peff@peff.net>
Date
Mar 20, 2013, 17:26 UTC
Message-ID
<20130320172640.GC10752@sigill.intra.peff.net>
In-Reply-To
<20130320170607.GB10752@sigill.intra.peff.net>
On Wed, Mar 20, 2013 at 01:06:07PM -0400, Jeff King wrote:
Show 14 quoted lines
> On Wed, Mar 20, 2013 at 12:30:47PM +0100, Johannes Sixt wrote:
> 
> > > I think that is OK, but I'm curious why this is a problem _now_, and not
> > > with the code prior to 97a83fa8. The old GIT_DEBUG_SEND_PACK was also
> > > just calling write() to descriptor 3.
> > 
> > Before this change, both affected commands completed and the trace file
> > was empty. Notice that in both test cases we only check for the absence of
> > certain lines, which is naturally true for an empty file, so that the
> > tests pass.
> 
> Hmm. The code in t5503 is similar, but before my patch used to actually
> use "test -s" to make sure that some trace output was written. Did it
> fail before 97a83fa8 (and does it pass now)?

Ah, I see. It did fail, and it was marked with NOT_MINGW. I think we can fix that now. Patch coming in a moment.

-Peff
Previous: Jeff KingNext: Jeff King
Message 5 of 11 in “t5700-clone-reference: send trace to fd 2, not 3, to please Windows git”
  1. t5700-clone-reference: send trace to fd 2, not 3, to please Windows gitJohannes Sixt, Mar 20, 2013
  2. Jeff KingMar 20, 2013
  3. Johannes SixtMar 20, 2013
  4. Jeff KingMar 20, 2013
  5. Jeff KingMar 20, 2013
  6. do not use GIT_TRACE_PACKET=3 in testsJeff King, Mar 20, 2013
  7. Eric SunshineMar 20, 2013
  8. Jeff KingMar 20, 2013
  9. Johannes SixtMar 21, 2013
  10. Junio C HamanoMar 21, 2013
  11. Junio C HamanoMar 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.