Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git
- From
Jeff King <peff@peff.net>
- Date
- Mar 20, 2013, 17:26 UTC
- Message-ID
- <20130320172640.GC10752@sigill.intra.peff.net>
- In-Reply-To
- <20130320170607.GB10752@sigill.intra.peff.net>
On Wed, Mar 20, 2013 at 01:06:07PM -0400, Jeff King wrote:
Show 14 quoted lines
> On Wed, Mar 20, 2013 at 12:30:47PM +0100, Johannes Sixt wrote: > > > > I think that is OK, but I'm curious why this is a problem _now_, and not > > > with the code prior to 97a83fa8. The old GIT_DEBUG_SEND_PACK was also > > > just calling write() to descriptor 3. > > > > Before this change, both affected commands completed and the trace file > > was empty. Notice that in both test cases we only check for the absence of > > certain lines, which is naturally true for an empty file, so that the > > tests pass. > > Hmm. The code in t5503 is similar, but before my patch used to actually > use "test -s" to make sure that some trace output was written. Did it > fail before 97a83fa8 (and does it pass now)?
Ah, I see. It did fail, and it was marked with NOT_MINGW. I think we can fix that now. Patch coming in a moment.
-Peff