Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

From: Jeff King <peff@peff.net>
Date: Mar 20, 2013, 09:33 UTC
Message-ID: <20130320093313.GA9482@sigill.intra.peff.net>
In-Reply-To: <5149724C.3060105@viscovery.net>

On Wed, Mar 20, 2013 at 09:24:44AM +0100, Johannes Sixt wrote:

Show 13 quoted lines

> From: Johannes Sixt <j6t@kdbg.org>
> 
> Two tests use GIT_TRACE=3 to dump debugging information of git. On
> Windows, however, bash is unable to set up file descriptor 3 correctly
> for its child process, so that git reports "Bad file descriptor" on
> every trace attempt. The 'git clone' test succeeds nevertheless because
> an empty trace file remains, and there is only a check for the
> absence of a particular line. But the 'git fetch' process ultimately
> hangs (the dynamics that lead to this surprising result have not been
> investigated).
> 
> Since we do not otherwise use stderr in the test cases, divert the
> trace dump to stderr.

I think that is OK, but I'm curious why this is a problem _now_, and not with the code prior to 97a83fa8. The old GIT_DEBUG_SEND_PACK was also just calling write() to descriptor 3.

> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  This fixes a regression introduced in

...in 97a83fa8, I assume.

-Peff