git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 0/5] Add git-credential support to git-send-email

From
Jeff King <peff@peff.net>
Date
Feb 11, 2013, 16:51 UTC
Message-ID
<20130211165136.GC16402@sigill.intra.peff.net>
In-Reply-To
<cover.1360599057.git.mina86@mina86.com>
On Mon, Feb 11, 2013 at 05:23:34PM +0100, Michal Nazarewicz wrote:
Show 5 quoted lines
> From: Michal Nazarewicz <mina86@mina86.com>
> 
> The third version of the patch with changes suggested by Jeff in the
> 4/5 patch.  Also credential_read and credential_write are now public
> functions in case someone wants to write a helper in perl.

Thanks, the changes you made look good. And I think it's a good idea to make the read/write functions public.

I have two minor comments, which I'll reply inline with. But even with those comments, I think this would be OK to merge.

-Peff
Previous: Jeff KingNext: Michal Nazarewicz
Message 13 of 16 in “[PATCHv3 0/5] Add git-credential support to git-send-email”
  1. Michal NazarewiczFeb 11, 2013
  2. 1/5 Git.pm: allow command_close_bidi_pipe to be called as methodMichal Nazarewicz, Feb 11, 2013
  3. 2/5 Git.pm: fix example in command_close_bidi_pipe documentationMichal Nazarewicz, Feb 11, 2013
  4. 3/5 Git.pm: allow pipes to be closed prior to calling command_close_bidi_pipeMichal Nazarewicz, Feb 11, 2013
  5. 4/5 Git.pm: add interface for git credential commandMichal Nazarewicz, Feb 11, 2013
  6. Jeff KingFeb 11, 2013
  7. Michal NazarewiczFeb 11, 2013
  8. Jeff KingFeb 11, 2013
  9. 5/5 git-send-email: use git credential to obtain passwordMichal Nazarewicz, Feb 11, 2013
  10. Jeff KingFeb 11, 2013
  11. Michal NazarewiczFeb 11, 2013
  12. Jeff KingFeb 11, 2013
  13. Jeff KingFeb 11, 2013
  14. Michal NazarewiczFeb 11, 2013
  15. Jeff KingFeb 11, 2013
  16. Michal NazarewiczFeb 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.