From: Jeff King <peff@peff.net>
Date: Mon, 11 Feb 2013 16:51:36 GMT
Subject: Re: [PATCHv3 0/5] Add git-credential support to git-send-email
Message-ID: <20130211165136.GC16402@sigill.intra.peff.net>
In-Reply-To: <cover.1360599057.git.mina86@mina86.com>

On Mon, Feb 11, 2013 at 05:23:34PM +0100, Michal Nazarewicz wrote:

> From: Michal Nazarewicz <mina86@mina86.com>
> 
> The third version of the patch with changes suggested by Jeff in the
> 4/5 patch.  Also credential_read and credential_write are now public
> functions in case someone wants to write a helper in perl.

Thanks, the changes you made look good. And I think it's a good idea to
make the read/write functions public.

I have two minor comments, which I'll reply inline with. But even with
those comments, I think this would be OK to merge.

-Peff