Re: [PATCH v3 09/11] t4014: more tests about appending s-o-b lines

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 28, 2013, 03:31 UTC
Message-ID: <20130128033146.GM8206@elie.Belkin>
In-Reply-To: <1359335515-13818-10-git-send-email-drafnel@gmail.com>

Brandon Casey wrote:

[...]

Show 14 quoted lines

> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -1021,4 +1021,246 @@ test_expect_success 'cover letter using branch description (6)' '
>  	grep hello actual >/dev/null
>  '
>  
> +append_signoff()
> +{
> +	C=`git commit-tree HEAD^^{tree} -p HEAD` &&
> +	git format-patch --stdout --signoff ${C}^..${C} |
> +		tee append_signoff.patch |
> +		sed -n "1,/^---$/p" |
> +		grep -n -E "^Subject|Sign|^$"
> +}

Is "grep -n" portable? I didn't find any uses of it elsewhere in the testsuite.

Style: checking exit status from format-patch, avoiding sed|grep pipeline:

	C=$(git commit-tree HEAD^ -p HEAD) &&
	git format-patch --stdout --signoff $C^..$C >append_signoff.patch &&
	awk '
		/^---$/ { exit; }
		/^Subject/ || /^Sign/ || /^$/ { print NR ":" $0 }
	' <append_signoff.patch >actual