Re: [PATCH 3/4] mergetool--lib: Add functions for finding available tools

From: John Keeping <john@keeping.me.uk>
Date: Jan 27, 2013, 23:04 UTC
Message-ID: <20130127230404.GX7498@serenity.lan>
In-Reply-To: <1359321886-80523-4-git-send-email-davvid@gmail.com>

On Sun, Jan 27, 2013 at 01:24:45PM -0800, David Aguilar wrote:

Show 16 quoted lines

> +filter_tools () {
> +	filter="$1"
> +	prefix="$2"
> +	(
> +		cd "$MERGE_TOOLS_DIR" &&
> +		for i in *
> +		do
> +			echo "$i"
> +		done
> +	) | sort | while read tool
> +	do
> +		setup_tool "$tool" 2>/dev/null &&
> +		(eval "$filter" "$tool") &&
> +		printf "$prefix$tool\n"
> +	done
> +}

Can we change this so that it does this:

    filter_tools () {
    	filter="$1"
    	(
    		cd "$MERGE_TOOLS_DIR" &&
    		for i in *
    		do
    			echo "$i"
    		done
    	) |
        while read tool
    	do
    		setup_tool "$tool" 2>/dev/null &&
    		(eval "$filter" "$tool") &&
    		echo "$tool"
    	done
    }

and keep the sorting and prefix in show_tool_help? This will make it easier to integrate the user-configured tools from git-config.

John