git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] config: Introduce diff.algorithm variable

From
Jeff King <peff@peff.net>
Date
Jan 15, 2013, 16:58 UTC
Message-ID
<20130115165822.GB29301@sigill.intra.peff.net>
In-Reply-To
<7v38y3a31k.fsf@alter.siamese.dyndns.org>
On Mon, Jan 14, 2013 at 01:05:27PM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> Michal Privoznik <mprivozn@redhat.com> writes:
> 
> > +static long parse_algorithm_value(const char *value)
> > +{
> > +	if (!value || !strcasecmp(value, "myers"))
> > +		return 0;
> 
> [diff]
> 	algorithm
> 
> should probably error out.
Definitely.
> Also it is rather unusual to parse the keyword values case insensitively.

Is it? "git grep strcasecmp" shows that we already do so in many cases (e.g., any bool option, core.autocrlf, receive.deny*, etc). Is there a reason to reject "Myers" here?

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 9 in “Rework git-diff algorithm selection”
  1. 0/3 Rework git-diff algorithm selectionMichal Privoznik, Jan 14, 2013
  2. 1/3 git-completion.bash: Autocomplete --minimal and --histogram for git-diffMichal Privoznik, Jan 14, 2013
  3. 2/3 config: Introduce diff.algorithm variableMichal Privoznik, Jan 14, 2013
  4. Junio C HamanoJan 14, 2013
  5. Jeff KingJan 15, 2013
  6. Junio C HamanoJan 15, 2013
  7. 3/3 diff: Introduce --diff-algorithm command line optionMichal Privoznik, Jan 14, 2013
  8. Junio C HamanoJan 14, 2013
  9. Michal PrivoznikJan 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.