From: Jeff King <peff@peff.net>
Date: Tue, 15 Jan 2013 16:58:23 GMT
Subject: Re: [PATCH v2 2/3] config: Introduce diff.algorithm variable
Message-ID: <20130115165822.GB29301@sigill.intra.peff.net>
In-Reply-To: <7v38y3a31k.fsf@alter.siamese.dyndns.org>

On Mon, Jan 14, 2013 at 01:05:27PM -0800, Junio C Hamano wrote:

> Michal Privoznik <mprivozn@redhat.com> writes:
> 
> > +static long parse_algorithm_value(const char *value)
> > +{
> > +	if (!value || !strcasecmp(value, "myers"))
> > +		return 0;
> 
> [diff]
> 	algorithm
> 
> should probably error out.

Definitely.

> Also it is rather unusual to parse the keyword values case insensitively.

Is it? "git grep strcasecmp" shows that we already do so in many cases
(e.g., any bool option, core.autocrlf, receive.deny*, etc). Is there a
reason to reject "Myers" here?

-Peff