Re: [PATCH 00/14] Remove unused code from imap-send.c

From: Jeff King <peff@peff.net>
Date: Jan 14, 2013, 06:06 UTC
Message-ID: <20130114060647.GA4359@sigill.intra.peff.net>
In-Reply-To: <1358141566-26081-1-git-send-email-mhagger@alum.mit.edu>

On Mon, Jan 14, 2013 at 06:32:32AM +0100, Michael Haggerty wrote:

> As discussed before [1], imap-send.c was copied from isync, including
> a lot of code that is not used within the git project.  This patch
> series rips a bunch of it out.

Thanks, this looks like a good direction.

I did not notice any problems reading through the patches, but my brain is frazzled from a day of flying. I missed the problem Jonathan noticed. :)

Some of the things you are removing are for advanced IMAP features that imap-send does not need. In theory, somebody might extend it to use them in the future. But since it has not seen any active feature development in years, and since anybody could resurrect the code by reverting your commits, I don't think it is a big risk.

I suspect you could go even further in ripping things out (e.g., I do not think a server will generate an untagged namespace response at all if we do not ask for it by issuing a namespace command). But you've certainly grabbed the low-hanging fruit that can mostly be verified by the compiler, and I don't know if it's worth the effort to go much further, as it would require a lot of manual verification (and understanding of IMAP, which will rot your brain).

-Peff