Re: [PATCH 01/14] imap-send.c: remove msg_data::flags, which was always zero
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jan 14, 2013, 05:57 UTC
- Message-ID
- <20130114055721.GD3125@elie.Belkin>
- In-Reply-To
- <1358141566-26081-2-git-send-email-mhagger@alum.mit.edu>
Hi,
Michael Haggerty wrote:
> This removes the need for function imap_make_flags(), so delete it, > too.
[...]
> --- a/imap-send.c > +++ b/imap-send.c
[...]
Show 5 quoted lines
> box = gctx->name; > prefix = !strcmp(box, "INBOX") ? "" : ctx->prefix; > cb.create = 0; > - ret = imap_exec_m(ctx, &cb, "APPEND \"%s%s\" %s", prefix, box, flagstr); > + ret = imap_exec_m(ctx, &cb, "APPEND \"%s%s\"", prefix, box);
Before this change, the command is
"APPEND" SP mailbox SP "{" msglen "}" CRLF. After this change, it leaves out the space before the brace. If I understand RFC3501 correctly, the space is required. Intentional?
With the below squashed in, Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
diff --git i/imap-send.c w/imap-send.c index 451d5027..f1c8f5a5 100644 --- i/imap-send.c +++ w/imap-send.c @@ -1296,7 +1296,7 @@ static int imap_store_msg(struct store *gctx, struct msg_data *msg) box = gctx->name; prefix = !strcmp(box, "INBOX") ? "" : ctx->prefix; cb.create = 0; - ret = imap_exec_m(ctx, &cb, "APPEND \"%s%s\"", prefix, box); + ret = imap_exec_m(ctx, &cb, "APPEND \"%s%s\" ", prefix, box); imap->caps = imap->rcaps; if (ret != DRV_OK) return ret;