git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib/vim: simplify instructions for old vim support

From
Jeff King <peff@peff.net>
Date
Jan 10, 2013, 21:34 UTC
Message-ID
<20130110213427.GA26138@sigill.intra.peff.net>
In-Reply-To
<20130110205427.GG16532@google.com>
On Thu, Jan 10, 2013 at 12:54:27PM -0800, Jonathan Nieder wrote:
Show 28 quoted lines
> Rely on the upstream filetype.vim instead of duplicating its rules in
> git's instructions for syntax highlighting support on pre-7.2 vim
> versions.
> 
> The result is a shorter contrib/vim/README.  More importantly, it lets
> us punt on maintenance of the autocmd rules.
> 
> So now when we fix the upstream gitsendemail rule in light of commit
> eed6ca7, new git users stuck on old vim reading contrib/vim/README can
> automagically get the fix without any further changes needed to git.
> 
> Once the world has moved on to vim 7.2+ completely, we can get rid of
> these instructions, but for now if they are this simple it's
> effortless to keep them.
> 
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Jeff King wrote:
> 
> > I'd argue that we should just remove contrib/vim at this point. It has
> > no actual files in it, only pointers to vim.org for pre-7.2 vim users.
> 
> I think that's reasonable.  Of course we can still discuss enhancements
> to the vim support on this list, but ultimately it's easiest to
> distribute and document such work upstream in the usual way for vim
> plugins.
> 
> How about this patch?

Yeah, I think this makes sense. I'd be fine with removing it entirely, but it doesn't hurt to err on the conservative side and leave it there. It's not like it's generating a huge maintenance burden, and with your patch, there is even less to maintain.

Acked-by: Jeff King <peff@peff.net>
-Peff
Previous: Jonathan NiederNext: Jonathan Nieder
Message 6 of 7 in “about vim contrib support”
  1. Manlio PerilloJan 10, 2013
  2. Jeff KingJan 10, 2013
  3. Manlio PerilloJan 10, 2013
  4. Jeff KingJan 10, 2013
  5. contrib/vim: simplify instructions for old vim supportJonathan Nieder, Jan 10, 2013
  6. Jeff KingJan 10, 2013
  7. Jonathan NiederJan 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.