From: Jeff King Date: Thu, 10 Jan 2013 21:34:27 GMT Subject: Re: [PATCH] contrib/vim: simplify instructions for old vim support Message-ID: <20130110213427.GA26138@sigill.intra.peff.net> In-Reply-To: <20130110205427.GG16532@google.com> On Thu, Jan 10, 2013 at 12:54:27PM -0800, Jonathan Nieder wrote: > Rely on the upstream filetype.vim instead of duplicating its rules in > git's instructions for syntax highlighting support on pre-7.2 vim > versions. > > The result is a shorter contrib/vim/README. More importantly, it lets > us punt on maintenance of the autocmd rules. > > So now when we fix the upstream gitsendemail rule in light of commit > eed6ca7, new git users stuck on old vim reading contrib/vim/README can > automagically get the fix without any further changes needed to git. > > Once the world has moved on to vim 7.2+ completely, we can get rid of > these instructions, but for now if they are this simple it's > effortless to keep them. > > Signed-off-by: Jonathan Nieder > --- > Jeff King wrote: > > > I'd argue that we should just remove contrib/vim at this point. It has > > no actual files in it, only pointers to vim.org for pre-7.2 vim users. > > I think that's reasonable. Of course we can still discuss enhancements > to the vim support on this list, but ultimately it's easiest to > distribute and document such work upstream in the usual way for vim > plugins. > > How about this patch? Yeah, I think this makes sense. I'd be fine with removing it entirely, but it doesn't hurt to err on the conservative side and leave it there. It's not like it's generating a huge maintenance burden, and with your patch, there is even less to maintain. Acked-by: Jeff King -Peff