Re: [RFC/PATCH] avoid SIGPIPE warnings for aliases

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 10, 2013, 00:18 UTC
Message-ID: <20130110001844.GC21054@google.com>
In-Reply-To: <7vehhu3u2y.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:

Show 14 quoted lines

>> But we still say "error: ... died of signal 13", because that comes from
>> inside wait_or_whine. So it is a separate issue whether or not
>> wait_or_whine should be silent on SIGPIPE (we already are on SIGINT and
>> SIGQUIT, as of some recent patches).
>>
>> The upside is that it is noise in this case that we would no longer see.
>> The downside is that we may be losing a clue when debugging server
>> problems, which do not expect to die from SIGPIPE.  Should it be an
>> optional run-command flag?
>
> Do we know if we are upstream of a pager that reads from us through
> a pipe (I think we should, especially in a case where we are the one
> who processed the "git -p $alias" option)?  Is there any other case
> where we would want to ignore child's death by SIGPIPE?

When we die early by SIGPIPE because output was piped to "head", I still think the early end of output is not notable enough to complain about.

I'm not sure whether there are SIGPIPE instances we really don't want to be silent about, though. I suspect not. ;-)

Compare <http://thread.gmane.org/gmane.comp.version-control.git/2062>, <http://thread.gmane.org/gmane.comp.version-control.git/48469/focus=48665>.

Thanks, Jonathan