Re: [RFC/PATCH] avoid SIGPIPE warnings for aliases

From: Jeff King <peff@peff.net>
Date: Jan 9, 2013, 20:51 UTC
Message-ID: <20130109205116.GA24605@sigill.intra.peff.net>
In-Reply-To: <7vr4lu3wx7.fsf@alter.siamese.dyndns.org>

On Wed, Jan 09, 2013 at 12:48:20PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> >   $ git lg -p
> >   [user hits 'q' to exit pager]
> >   error: git lgbase --more-options died of signal 13
> >   fatal: While expanding alias 'lg': 'git lgbase --more-options': Success
> >
> > Many users won't see this, because we execute the external
> > command with the shell, and a POSIX shell will silently
> > rewrite the signal-death exit code into 128+signal, and we
> > will treat it like a normal exit code. However, this does
> > not always happen:
> 
> So... with the "flip the sign of the exit code when caught a signal"
> patch applied to 'next', do people still see this issue?

They see half. The patch you've applied clears up the "While expanding...: Success" message.

But we still say "error: ... died of signal 13", because that comes from inside wait_or_whine. So it is a separate issue whether or not wait_or_whine should be silent on SIGPIPE (we already are on SIGINT and SIGQUIT, as of some recent patches).

The upside is that it is noise in this case that we would no longer see. The downside is that we may be losing a clue when debugging server problems, which do not expect to die from SIGPIPE. Should it be an optional run-command flag?

-Peff