Re: [PATCH v8 0/3] submodule update: add --remote for submodule's upstream changes
- From
Heiko Voigt <hvoigt@hvoigt.net>
- Date
- Dec 21, 2012, 08:18 UTC
- Message-ID
- <20121221081803.GA560@book.hvoigt.net>
- In-Reply-To
- <cover.1355932282.git.wking@tremily.us>
Hi,
On Wed, Dec 19, 2012 at 11:03:30AM -0500, wking@tremily.us wrote:
Show 18 quoted lines
> From: "W. Trevor King" <wking@tremily.us> > > Comments on v7 seem to have petered out, so here's v8. Changes since > v7: > > * Series based on gitster/master instead of v1.8.0. > * In Documentation/config.txt, restored trailing line of > submodule.<name>.update documentation, which I had accidentally > removed in v7. > * In Documentation/git-submodule.txt, make --no-fetch example in the > --remote description more general, following Phil's suggestion. > * In git-submodule.sh: > * Remove accidental "ges" line. > * Use the submodule's default remote to determine which tracking > branch to fetch. In v7 I'd been using the superproject's default > remote. > * In cmd_add(), use sm_name instead of sm_path to store the --branch > option (catching up with 73b0898).
Sorry, I was not able to follow the discussion that closely lately but I like the outcome. For me there is nothing to change or add functionality wise. Thanks.
Cheers Heiko