git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] Makefile: remove tracking of TCLTK_PATH

From
Christian Couder <chriscool@tuxfamily.org>
Date
Dec 17, 2012, 07:22 UTC
Message-ID
<20121217.082241.794967023844368825.chriscool@tuxfamily.org>
In-Reply-To
<7v4njlpaet.fsf@alter.siamese.dyndns.org>
From: Junio C Hamano <gitster@pobox.com>
Show 15 quoted lines
>
> Christian Couder <chriscool@tuxfamily.org> writes:
> 
>> It looks like we are tracking the value of TCLTK_PATH in the main
>> Makefile for no good reason, as this is done in git-gui too and the
>> GIT-GUI-VARS is not used in the Makefile.
> 
> This was added to the main Makefile when we slurped gitk to our
> project at the top-level, so I am not surprised if git-gui were
> not depending on it at all.
> 
> A better explanation is that t62ba514 (Move gitk to its own
> subdirectory, 2007-11-17) should have moved these lines to
> gitk-git/Makefile (and I think we should move them there in a
> separate patch).
Yeah, I just sent an updated patch series that does this.

Thanks, Christian.

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “Makefile: remove tracking of TCLTK_PATH”
  1. 1/2 Makefile: remove tracking of TCLTK_PATHChristian Couder, Dec 16, 2012
  2. Junio C HamanoDec 17, 2012
  3. Christian CouderDec 17, 2012
  4. Junio C HamanoDec 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.