From: Christian Couder <chriscool@tuxfamily.org>
Date: Mon, 17 Dec 2012 07:22:41 GMT
Subject: Re: [PATCH v2 1/2] Makefile: remove tracking of TCLTK_PATH
Message-ID: <20121217.082241.794967023844368825.chriscool@tuxfamily.org>
In-Reply-To: <7v4njlpaet.fsf@alter.siamese.dyndns.org>

From: Junio C Hamano <gitster@pobox.com>
>
> Christian Couder <chriscool@tuxfamily.org> writes:
> 
>> It looks like we are tracking the value of TCLTK_PATH in the main
>> Makefile for no good reason, as this is done in git-gui too and the
>> GIT-GUI-VARS is not used in the Makefile.
> 
> This was added to the main Makefile when we slurped gitk to our
> project at the top-level, so I am not surprised if git-gui were
> not depending on it at all.
> 
> A better explanation is that t62ba514 (Move gitk to its own
> subdirectory, 2007-11-17) should have moved these lines to
> gitk-git/Makefile (and I think we should move them there in a
> separate patch).

Yeah, I just sent an updated patch series that does this.

Thanks,
Christian.