Re: [RFC/PATCH 4/5] completion: get rid of compgen

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Nov 17, 2012, 11:00 UTC
Message-ID: <20121117110031.GE12052@goldbirke>
In-Reply-To: <1353116298-11798-5-git-send-email-felipe.contreras@gmail.com>

On Sat, Nov 17, 2012 at 02:38:17AM +0100, Felipe Contreras wrote:

Show 22 quoted lines

> The functionality we use is very simple, plus, this fixes a known
> breakage 'complete tree filename with metacharacters'.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/completion/git-completion.bash | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 975ae13..ad3e1fe 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -227,7 +227,11 @@ fi
>  
>  __gitcompadd ()
>  {
> -	COMPREPLY=($(compgen -W "$1" -P "$2" -S "$4" -- "$3"))
> +	for x in $1; do
> +		if [[ "$x" = "$3"* ]]; then
> +			COMPREPLY+=("$2$x$4")
> +		fi
> +	done

The whole point of creating __gitcomp_nl() back then was to fill COMPREPLY without iterating through all words in the wordlist, making completion faster for large number of words, e.g. a lot of refs, or later a lot of symbols for 'git grep' in a larger project.

The loop here kills that optimization.

Show 5 quoted lines

>  }
>  
>  # Generates completion reply with compgen, appending a space to possible
> -- 
> 1.8.0