git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 3/5] completion: trivial test improvement

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 17, 2012, 01:38 UTC
Message-ID
<1353116298-11798-4-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1353116298-11798-1-git-send-email-felipe.contreras@gmail.com>

Instead of passing a dummy "", let's check if the last character is a space, and then move the _cword accordingly.

Apparently we were passing "" all the way to compgen, which fortunately expanded it to nothing.

Lets do the right thing though.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t9902-completion.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index cbd0fb6..0b5e1f5 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -51,6 +51,7 @@ run_completion ()
 	local _cword
 	_words=( $1 )
 	(( _cword = ${#_words[@]} - 1 ))
+	test "${1: -1}" == ' ' && (( _cword += 1 ))
 	__git_wrap__git_main && print_comp
 }
 
@@ -156,7 +157,7 @@ test_expect_success '__gitcomp - suffix' '
 '
 
 test_expect_success 'basic' '
-	run_completion "git \"\"" &&
+	run_completion "git " &&
 	# built-in
 	grep -q "^add \$" out &&
 	# script
-- 
1.8.0
Previous: Felipe ContrerasNext: SZEDER Gábor
Message 4 of 15 in “completion: compgen/compadd cleanups”
  1. 0/5 completion: compgen/compadd cleanupsFelipe Contreras, Nov 17, 2012
  2. 1/5 completion: get rid of empty COMPREPLY assignmentsFelipe Contreras, Nov 17, 2012
  3. 2/5 completion: add new __gitcompadd helperFelipe Contreras, Nov 17, 2012
  4. 3/5 completion: trivial test improvementFelipe Contreras, Nov 17, 2012
  5. SZEDER GáborNov 17, 2012
  6. 4/5 completion: get rid of compgenFelipe Contreras, Nov 17, 2012
  7. SZEDER GáborNov 17, 2012
  8. Felipe ContrerasNov 17, 2012
  9. SZEDER GáborNov 17, 2012
  10. Felipe ContrerasNov 17, 2012
  11. Felipe ContrerasNov 18, 2012
  12. 5/5 completion: refactor __gitcomp_1Felipe Contreras, Nov 17, 2012
  13. SZEDER GáborNov 17, 2012
  14. Felipe ContrerasNov 17, 2012
  15. SZEDER GáborNov 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.