git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] ensure that relative submodule url needs ./ or ../

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Nov 13, 2012, 08:35 UTC
Message-ID
<20121113083510.GC38188@book.hvoigt.net>
In-Reply-To
<20121113083233.GA38188@book.hvoigt.net>

Even though a relative path can be without them the documentation explicitely talks about them. Lets ensure that behavior with a test.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
 t/t7400-submodule-basic.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
index 5397037..3c2afa6 100755
--- a/t/t7400-submodule-basic.sh
+++ b/t/t7400-submodule-basic.sh
@@ -506,6 +506,18 @@ test_expect_success 'set up for relative path tests' '
 	)
 '
 
+test_expect_success 'subrepo is NOT considered a relative path"' '
+	(
+		cd reltest &&
+		cp pristine-.git-config .git/config &&
+		cp pristine-.gitmodules .gitmodules &&
+		git config -f .gitmodules submodule.sub.url "subrepo" &&
+		git config remote.origin.url "$submodurl" &&
+		git submodule init &&
+		test "$(git config submodule.sub.url)" = subrepo
+	)
+'
+
 test_expect_success '../subrepo works with URL - ssh://hostname/repo' '
 	(
 		cd reltest &&
-- 
1.8.0.3.gaed4666
Previous: Heiko VoigtNext: Heiko Voigt
Message 6 of 7 in “git commit/push can fail silently when clone omits ".git"”
  1. Jeffrey S. HaemerNov 4, 2012
  2. Jeff KingNov 8, 2012
  3. Heiko VoigtNov 9, 2012
  4. 0/3 fix cloning superprojects from "."Heiko Voigt, Nov 13, 2012
  5. 1/3 Fix relative submodule setup of submodule testsHeiko Voigt, Nov 13, 2012
  6. 2/3 ensure that relative submodule url needs ./ or ../Heiko Voigt, Nov 13, 2012
  7. 3/3 fix corner case for relative submodule path calculationHeiko Voigt, Nov 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.