git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] fix cloning superprojects from "."

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Nov 13, 2012, 08:32 UTC
Message-ID
<20121113083233.GA38188@book.hvoigt.net>
In-Reply-To
<20121109184225.GA1190@book.hvoigt.net>
Hi,
On Fri, Nov 09, 2012 at 07:42:26PM +0100, Heiko Voigt wrote:
Show 5 quoted lines
> Since this is a change in behaviour I would like to further think about
> the implications this brings if we fix this. Not sure how many people
> clone from ".". The correct behavior (as documented) is the one you
> introduce with your patch. If we decide to fix this we should also correct
> the path calculation in git-submodule.sh.

Ok I think this corner case is not that commonly used since most people work with remote remotes which you can not cd into to clone from ".".

Here is a patch series to clean this handling up.
Cheers Heiko
Heiko Voigt (3):
  Fix relative submodule setup of submodule tests
  ensure that relative submodule url needs ./ or ../
  fix corner case for relative submodule path calculation
 git-submodule.sh             | 22 +++++++++++++++++
 t/t7400-submodule-basic.sh   | 56 ++++++++++++++++++++++++++++++++++++++++++++
 t/t7403-submodule-sync.sh    |  2 ++
 t/t7406-submodule-update.sh  |  2 ++
 t/t7407-submodule-foreach.sh |  2 ++
 t/t7506-status-submodule.sh  |  2 ++
 6 files changed, 86 insertions(+)
-- 
1.8.0.3.gaed4666
Previous: Heiko VoigtNext: Heiko Voigt
Message 4 of 7 in “git commit/push can fail silently when clone omits ".git"”
  1. Jeffrey S. HaemerNov 4, 2012
  2. Jeff KingNov 8, 2012
  3. Heiko VoigtNov 9, 2012
  4. 0/3 fix cloning superprojects from "."Heiko Voigt, Nov 13, 2012
  5. 1/3 Fix relative submodule setup of submodule testsHeiko Voigt, Nov 13, 2012
  6. 2/3 ensure that relative submodule url needs ./ or ../Heiko Voigt, Nov 13, 2012
  7. 3/3 fix corner case for relative submodule path calculationHeiko Voigt, Nov 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.