git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: change symlink

From
Jeff King <peff@peff.net>
Date
Oct 31, 2012, 13:44 UTC
Message-ID
<20121031134432.GA24518@sigill.intra.peff.net>
In-Reply-To
<20121031123057.GE30879@sigill.intra.peff.net>
On Wed, Oct 31, 2012 at 08:30:57AM -0400, Jeff King wrote:
> Something like this seems to fix it for me, but I am not sure if that
> would affect other callers.
> [...]
> +		return !is_dir || !S_ISGITLINK(istate->cache[pos]->ce_mode);
That's completely wrong, of course. It should be:
  return is_dir && !S_ISGITLINK(...);

(we found an index entry, so if it isn't a directory, then we know that it is not untracked, and should return 0).

With that, we at least pass the test suite.
-Peff
Previous: Jeff King
Message 12 of 12 in “change symlink”
  1. shawn wilsonOct 30, 2012
  2. Andreas SchwabOct 30, 2012
  3. shawn wilsonOct 30, 2012
  4. Andreas SchwabOct 30, 2012
  5. shawn wilsonOct 30, 2012
  6. Andreas SchwabOct 30, 2012
  7. shawn wilsonOct 30, 2012
  8. Andreas SchwabOct 30, 2012
  9. shawn wilsonOct 30, 2012
  10. Jeff KingOct 31, 2012
  11. Jeff KingOct 31, 2012
  12. Jeff KingOct 31, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.