From: Jeff King <peff@peff.net>
Date: Wed, 31 Oct 2012 13:44:32 GMT
Subject: Re: change symlink
Message-ID: <20121031134432.GA24518@sigill.intra.peff.net>
In-Reply-To: <20121031123057.GE30879@sigill.intra.peff.net>

On Wed, Oct 31, 2012 at 08:30:57AM -0400, Jeff King wrote:

> Something like this seems to fix it for me, but I am not sure if that
> would affect other callers.
> [...]
> +		return !is_dir || !S_ISGITLINK(istate->cache[pos]->ce_mode);

That's completely wrong, of course. It should be:

  return is_dir && !S_ISGITLINK(...);

(we found an index entry, so if it isn't a directory, then we know that
it is not untracked, and should return 0).

With that, we at least pass the test suite.

-Peff