Re: [PATCH] git-send-email: skip RFC2047 quoting for ASCII subjects

From: Krzysztof Mazur <krzysiek@podlesie.net>
Date: Oct 25, 2012, 11:12 UTC
Message-ID: <20121025111217.GA3688@shrek.podlesie.net>
In-Reply-To: <20121025090149.GC8390@sigill.intra.peff.net>

On Thu, Oct 25, 2012 at 05:01:49AM -0400, Jeff King wrote:

Show 5 quoted lines

> 
> Hmm. What is this patch on top of? It looks like it is on top of your
> original patch, but when I tried it on top of that, it does not apply
> either, and the index lines in the patch do not mention a sha1 that I do
> not have.

Sorry, it's against km/send-email-compose-encoding (or current next)
+ "git-send-email: use compose-encoding for Subject".

Show 5 quoted lines

> 
> Do you mind re-rolling a final 2-patch series with:
> 
>   1. Your original patch and this one squashed together, with an
>      appropriate commit message.

I think that it's better to do refactoring and fix for ASCII in separate patches. Maybe we should reverse order of first two patches. This first will do refactoring and the second will just replace quote_rfc2047() with quote_subject() in "broken" encoding case and add test for this problem.

Show 6 quoted lines

> 
>   2. The second "quote when we see '=?'" patch.
> 
> Thanks.
> 
> -Peff

ok, I will resend the final series.

I need also to fix "git-send-email: use compose-encoding for Subject" patch. Now it's depends both on this series and km/send-email-compose-encoding branch.

Krzysiek