Re: [PATCH] git-send-email: skip RFC2047 quoting for ASCII subjects

From: Jeff King <peff@peff.net>
Date: Oct 24, 2012, 08:46 UTC
Message-ID: <20121024084636.GA23500@sigill.intra.peff.net>
In-Reply-To: <1351065815-22416-1-git-send-email-krzysiek@podlesie.net>

On Wed, Oct 24, 2012 at 10:03:35AM +0200, Krzysztof Mazur wrote:

Show 8 quoted lines

> The git-send-email always use RFC2047 subject quoting for files
> with "broken" encoding - non-ASCII files without Content-Transfer-Encoding,
> even for ASCII subjects. Now for ASCII subjects the RFC2047 quoting will be
> skipped.
> [...]
> -	if ($broken_encoding{$t} && !is_rfc2047_quoted($subject)) {
> +	if ($broken_encoding{$t} && !is_rfc2047_quoted($subject) &&
> +			($subject =~ /[^[:ascii:]]/)) {

Is that test sufficient? We would also need to encode if it has rfc2047 specials, no?

It looks like we use the same regex elsewhere. Maybe this would be a good chance to abstract out a needs_rfc2047_quoting while we are in the area?

Other than that, I did not see anything wrong with the patch.

-Peff