git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Fix crash when not using themed widgets

From
Paul Mackerras <paulus@samba.org>
Date
Oct 21, 2012, 22:22 UTC
Message-ID
<20121021222234.GB7407@bloggs.ozlabs.ibm.com>
In-Reply-To
<1349644874-22988-1-git-send-email-mk@acc.umu.se>
On Sun, Oct 07, 2012 at 11:21:14PM +0200, Marcus Karlsson wrote:
Show 18 quoted lines
> When configured not to use themed widgets gitk may crash on launch with
> a message that says that the image "bm-left disabled bm-left-gray"
> doesn't exist. This happens when the left and right arrow buttons are
> created.
> 
> The crash can be avoided by configuring the buttons differently
> depending on whether or not themed widgets are used. If themed widgets
> are not used then only set the images to bm-left and bm-right
> respectively, and keep the old behavior when themed widgets are used.
> 
> The previous behaviour was added in f062e50f to work around a bug in Tk
> on OS X where the disabled state did not display properly. The buttons
> may still not display correctly, however the workaround added in
> f062e50f will still apply if gitk is used with themed widgets.
> 
> Make gitk not crash on launch when not using themed widgets.
> 
> Signed-off-by: Marcus Karlsson <mk@acc.umu.se>
Thanks, applied.
Paul.
Previous: Marcus Karlsson
Message 2 of 2 in “gitk: Fix crash when not using themed widgets”
  1. gitk: Fix crash when not using themed widgetsMarcus Karlsson, Oct 7, 2012
  2. Paul MackerrasOct 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.