From: Paul Mackerras <paulus@samba.org>
Date: Sun, 21 Oct 2012 22:22:34 GMT
Subject: Re: [PATCH] gitk: Fix crash when not using themed widgets
Message-ID: <20121021222234.GB7407@bloggs.ozlabs.ibm.com>
In-Reply-To: <1349644874-22988-1-git-send-email-mk@acc.umu.se>

On Sun, Oct 07, 2012 at 11:21:14PM +0200, Marcus Karlsson wrote:
> When configured not to use themed widgets gitk may crash on launch with
> a message that says that the image "bm-left disabled bm-left-gray"
> doesn't exist. This happens when the left and right arrow buttons are
> created.
> 
> The crash can be avoided by configuring the buttons differently
> depending on whether or not themed widgets are used. If themed widgets
> are not used then only set the images to bm-left and bm-right
> respectively, and keep the old behavior when themed widgets are used.
> 
> The previous behaviour was added in f062e50f to work around a bug in Tk
> on OS X where the disabled state did not display properly. The buttons
> may still not display correctly, however the workaround added in
> f062e50f will still apply if gitk is used with themed widgets.
> 
> Make gitk not crash on launch when not using themed widgets.
> 
> Signed-off-by: Marcus Karlsson <mk@acc.umu.se>

Thanks, applied.

Paul.