Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 9, 2012, 10:19 UTC
- Message-ID
- <20121009101953.GB28120@elie.Belkin>
- In-Reply-To
- <5073F2C0.6000504@drmicha.warpmail.net>
Michael J Gruber wrote:
> Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41:
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> > > Tested with Subversion 1.6.18.
[...]
> I haven't checked other svn versions but this approach looks perfectly > sensible. It makes us test branch names which can't even be created > easily with current svn. Does svn really deserve this much attention? ;)
Thanks for the quick and thorough feedback. I'm glad to hear it seems sane. ;-)
> Seriously, our tests prepare us well for an svn remote helper...
That might be a good reason to make a mock implementation of the existing git-svn interface on top of git-remote-svn. Sounds fun but hard.
Ciao, Jonathan